Add support for JFrog artifactory.#1553
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1553 +/- ##
==========================================
- Coverage 76.96% 76.85% -0.12%
==========================================
Files 160 162 +2
Lines 14757 14945 +188
==========================================
+ Hits 11358 11486 +128
- Misses 2266 2325 +59
- Partials 1133 1134 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Remove unused pathCache field from PublishedStorage struct - Remove unused md5s accumulation in Filelist() - Fix unchecked error return on expectedOut.Write in config_test.go - Suppress unused linter on configFileYAML/configFileYAMLError constants (retained to avoid merge conflicts with feat/pls/gcs-support) - Add --timeout=10m to golangci-lint workflow
v0.5.14 introduced a `1 << 31` constant assigned to an `int` variable in lzma/reader.go, which overflows on 32-bit architectures (i386, armhf). v0.5.15 fixes this by using int64.
neolynx
added
needs rebase
| AZURE_STORAGE_ACCESS_KEY: "Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==" | ||
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| JFROG_URL: ${{ secrets.JFROG_URL }} |
There was a problem hiding this comment.
Not necessarily blocking this MR, but what would it look like to get an Artifactory instance running for these integration tests? It's not clear what their free/OSS offering would take to host or if it supports the functionality we need here.
There was a problem hiding this comment.
sorry I forgot to clean this out.
Unfortunately only a 30 day trial is available for JFrog as far as I am aware, and i don't think it would be usable in ci .
I would understand if you didn't think adding support for this was very interesting. I needed this feature for a project and thought I would share.
There was a problem hiding this comment.
No I think it's very interesting, having used Artifactory's built in "Debian Snapshots" before, this would be a welcome improvement :)
I was wondering how we could see it in action, but if it's worked for your personal needs, that's a good vote of confidence.
|
I was able to publish a small local repo to JFrog, and it seemed to work
fine. This week I'll be testing pushing ubuntu mirrors snapshots to JFrog,
so If I find any issues I will update the PR.
Le lun. 13 avr. 2026 à 12:10, iofq ***@***.***> a écrit :
… ***@***.**** commented on this pull request.
------------------------------
In .github/workflows/ci.yml
<#1553 (comment)>:
> @@ -100,6 +100,9 @@ jobs:
AZURE_STORAGE_ACCESS_KEY: "Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw=="
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+ JFROG_URL: ${{ secrets.JFROG_URL }}
No I think it's very interesting, having used Artifactory's built in
"Debian Snapshots" before, this would be a welcome improvement :)
I was wondering how we could see it in action, but if it's worked for your
personal needs, that's a good vote of confidence.
—
Reply to this email directly, view it on GitHub
<#1553 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAHYAIPRWUTJPBKYVOHZPL4VUGNTAVCNFSM6AAAAACXPTAVMKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DCMBQGE3DGMZQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
| # # JFrog URL | ||
| # url: "https://artifactory.example.com/artifactory/" | ||
| # # Repository | ||
| # repository: apt-local |
There was a problem hiding this comment.
We should make it clear that this is intended for a "generic" Jfrog repo, and detail any other settings/setup that were needed on the Artifactory side if any.
| "}") | ||
| } | ||
|
|
||
| func (s *ConfigSuite) TestLoadYAMLConfig(c *C) { |
There was a problem hiding this comment.
Looks like a few tests were removed here, was that intentional?
| github.com/aws/aws-sdk-go-v2/service/s3 v1.67.1 | ||
| github.com/aws/smithy-go v1.22.1 | ||
| github.com/google/uuid v1.6.0 | ||
| github.com/jfrog/jfrog-client-go v1.55.0 |
There was a problem hiding this comment.
I believe if we add a new dependency, it should also be added to debian/control to facilitate debian source builds. However I'm not super familiar with this process and will defer to @neolynx on if this is necessary now and if so, what the process is (since it doesn't look like jfrog-client-go is currently packaged for Debian)
There was a problem hiding this comment.
I guess what I can do is gate JFrog support out of Debian builds for now (build tags / packaging split), so Debian source builds remain reproducible. Let me know how to proceed.
|
I was "playing" with this in my customer's environment today. I had a small bug but now it's working beautifully. I was able to publish, update, and delete from JFrog. I will update the PR and address your comments shortly. |
3 participants
Description of the Change
Add support for JFrog artifactory.
One could use a "generic" JFrog repository (not debian/apt compatible repo: we wouldn't want it to recalculate Release files)
Checklist
AUTHORS